ashb commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja
directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r263313874
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -22,6 +22,9 @@
{% block head_css %}
{{ super() }}
<link href="{{ url_for_asset('bootstrap-toggle.min.css') }}"
rel="stylesheet" type="text/css">
+ <meta name="dag-id" content="{{ dag.dag_id }}">
Review comment:
For consistency it probably makes sense to have these in meta, but having
`<html data-dag-id="...">` (or on some other element in the body) would be
"semantically correct" for me on this page, as the DAG ID is a property of the
document/content.
But I'm also fine with it staying as a meta tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
