JavierLopezT commented on pull request #9008: URL: https://github.com/apache/airflow/pull/9008#issuecomment-691984621
The other day I took a look at this code again, and indeed the code is ugly as f**k. @ashb I re-read your comment and I will try to narrow the scope of my question regarding your comment. When you say _the existing conn_uri approach_ are you referring to the way in this script, or something else? From your second bullet, I understand that you say for example (using the picture of my previous comment), that if I call the secret data_snowflake, since it won't be found, all data_airflow_master_user, data_api_google_drive and data_airflow_backend_database would be fetched? I have been thinking also about what you said of extra parameters. It sounds good. But, what happens if you want to save something that it is not used in the connection but somewhere else? Then the conn will take those fields in the extra and the conn will fail. I came up with adding some suffix or prefix to those fields, like no_whatever or whatever_dont_use, but in some manner that sounds counterintuitive for me as well. So I am not sure which would be a good solution. What do you think? Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
