ashb opened a new pull request #10933: URL: https://github.com/apache/airflow/pull/10933
As we switch over to using row-level locks more in the scheduler, it's is better if we don't have transactions hang around being open "for ever", otherwise an errant process may end up holding on to a lock for a lot longer than we intend. For example, on mysql the default lock wait timeout is 50s. We could have set `innodb_lock_wait_timeout` to a shorter value -- but that only affects the waiting side, not the locking side. So instead we set an idle timeout -- if the transaction is not doing anything we ask the DB server to kill it, ending the transaction and freeing any held row locks. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
