potiuk commented on a change in pull request #10933:
URL: https://github.com/apache/airflow/pull/10933#discussion_r488026198
##########
File path: airflow/utils/orm_event_handlers.py
##########
@@ -32,6 +32,9 @@ def setup_event_handlers(engine):
"""
Setups event handlers.
"""
+
+ idle_session_timeout = conf.getint("core",
"sql_alchemy_idle_transaction_timeout", fallback=10)
Review comment:
See my other comment - I believe it (might) have a profound impact on
how MySQL server behaves (especially) because effectively each client will be -
in some cases - continuously closing and opening the connections, where
previously they were opened for up to 8 hours by default. So we REALLY need to
describe it and I think we have to understand the impact and describe it also
for the MySQL users who would like to enable it. I guess setting it by default
(like it is currently) to a low value is rather a bad idea in those cases so
quite a bit more complex logic shoudl be implemented here - for example it
could be set to a low value only when HA scheduler is enabled (when we get to
take a look at it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
