ryanahamilton opened a new pull request #10944:
URL: https://github.com/apache/airflow/pull/10944
Attempting to make one of the more complex UI interactions more intuitive
with the following edits:
### Task Instance Modal
- Adds "X" button to close modal in the top-right as intended by Bootstrap
patterns ("Close" button in the bottom-right still persists as well).
- Cleaned up the presentation the modal header by adding "Task Instance/at"
label/prefixes and moving the very randomly placed Filter (icon) button down
with the options below as a "Filter Upstream" button.
- Removed the "primary" button styling from each of the buttons in the group
row ("Task Instance Details", "Rendered", etc.). This wasn't appropriate usage
of a "primary" styling as that designation is used to establish a visual
hierarchy—in this case all of the actions are considered comparable.
- Re-ordered each "action" form. (buttons on right instead of left) Forms
should flow top to bottom OR left to right. This aligns with the user flow of
electing the related options and then submitting the form.
- Improved the accessibility of the "action" forms by refactoring the
underlying markup/scripting to each be wrapped in their own `<form></form>`
tags so that they can be individually submitted via keyboard (depending on
focus).
- Updated the screenshot of this modal [in the
docs](https://airflow.apache.org/docs/stable/ui.html#task-instance-context-menu).
| Before | After |
|---|---|
|
|
|
### DAG Modal
Applies patterns consistent with updates to the Task Instance Modal:
- Added "DAG:" prefix to the modal header
- Added "X" close button in top-right of modal
| Before | After |
|---|---|
|
|
|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
