kaxil commented on a change in pull request #10897:
URL: https://github.com/apache/airflow/pull/10897#discussion_r488895516
##########
File path: airflow/models/dag.py
##########
@@ -1621,6 +1621,13 @@ def sync_to_db(self, sync_time=None, session=None):
"""
self.bulk_sync_to_db([self], sync_time, session)
+ def get_default_view(self):
+ """This is only there for backward compatible jinja2 templates"""
+ if self.default_view is None:
+ return conf.get('webserver', 'dag_default_view').lower()
+ else:
+ return self.default_view
Review comment:
I kept it there for parity between Dag and DagModel, otherwise dag.html
and dags.html might use or the other depending on if we are using Dag or
DagModel
The other option is to create a Database migration to fill all the `null`
values, WDYT? @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
