pgagnon commented on a change in pull request #4772: [AIRFLOW-3937]
KubernetesPodOperator support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#discussion_r263831756
##########
File path:
airflow/contrib/kubernetes/kubernetes_request_factory/kubernetes_request_factory.py
##########
@@ -140,6 +140,27 @@ def extract_env_and_secrets(pod, req):
KubernetesRequestFactory.add_secret_to_env(env, secret)
req['spec']['containers'][0]['env'] = env
+ if pod.envs_from_configmaps or pod.envs_from_secrets:
+ req['spec']['containers'][0]['envFrom'] = []
+
+ for configmap in pod.envs_from_configmaps:
+ req['spec']['containers'][0]['envFrom'].append(
+ {
+ 'configMapRef': {
+ 'name': configmap
+ }
+ }
+ )
+
+ for secret in pod.envs_from_secrets:
+ req['spec']['containers'][0]['envFrom'].append(
Review comment:
@ashb Reading the K8s api docs at
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#envfromsource-v1-core
my understanding is that the difference is that `envFrom.valueFrom.secretKey`
will populate a pod with an environment variable for all keys in a secret while
`env.valueFrom.secretKeyRef` will add a single environment variable that refers
to a single key in a secret.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
