ashb commented on a change in pull request #10956:
URL: https://github.com/apache/airflow/pull/10956#discussion_r489365115
##########
File path: airflow/utils/dag_processing.py
##########
@@ -1037,58 +1028,50 @@ def wait_until_finished(self):
while not processor.done:
time.sleep(0.1)
- def _collect_results_from_processor(self, processor):
+ def _collect_results_from_processor(self, processor) -> None:
self.log.debug("Processor for %s finished", processor.file_path)
Stats.decr('dag_processing.processes')
last_finish_time = timezone.utcnow()
if processor.result is not None:
- dags, count_import_errors = processor.result
+ count_import_errors = processor.result
else:
self.log.error(
"Processor for %s exited with return code %s.",
processor.file_path, processor.exit_code
)
- dags, count_import_errors = [], -1
+ count_import_errors = -1
stat = DagFileStat(
- num_dags=len(dags),
+ # TODO: Return number of dags, number of errors?
+ num_dags=0,
Review comment:
Yes, good idea, I'll change processor to return `(num_dags,num_errors)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
