potiuk opened a new issue #10984: URL: https://github.com/apache/airflow/issues/10984
We need to make sure that changes to "scripts" will not be a problem for non-rebased commits **Apache Airflow version**: master /v1-10-test **What happened**: When we introduce changes to scripts building image, this is is not obvious how they will work for non-rebased commits. We are using the "workflow_run" type of workflow which builds the images and it uses scripts from master to build images from the PR (the main reason for that is security - so that PRs cannot "inject" any code into the build process without a review. The problem is that when such change is merged to master, it start bein used for all PRs also those that are not rebased yet. In such case "master" scripts are used to build "pre-master" images. It already caused some problems: For example #10943 caused not rebased PRs to fail. **What you expected to happen**: Merging a new version of scrips should not fail recent non-rebased PRs. It should be entirely possible to simulate such a situation in CI before merging such change. We should simply test if a new version of scripts is backwards compatible and if it can build the image from parent commit. **Anything else we need to know**: <!-- How often does this problem occur? Once? Every time etc? Any relevant logs to include? Put them here in side a detail tag: <details><summary>x.log</summary> lots of stuff </details> --> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
