ashb commented on a change in pull request #10162:
URL: https://github.com/apache/airflow/pull/10162#discussion_r490161213



##########
File path: airflow/www/templates/airflow/master.html
##########
@@ -19,6 +19,14 @@
 
 {% extends 'appbuilder/baselayout.html' %}
 
+{% block page_title -%}
+  {% if title is defined -%}
+    {{ title }} - {{ app_name }}

Review comment:
       Isn't this going to show "DAGs - Airflow - Airflow"? for the task.html 
template?
   
   It sounds like it is probably worth defining a `title` block in every page, 
that way we don't need the app_name in all of them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to