pcandoalmeida commented on a change in pull request #10162:
URL: https://github.com/apache/airflow/pull/10162#discussion_r490425574



##########
File path: airflow/www/extensions/init_jinja_globals.py
##########
@@ -44,6 +44,7 @@ def init_jinja_globals(app):
 
     def prepare_jinja_globals():
         extra_globals = {
+            'app_name': conf.get(section="webserver", key="site_title", 
fallback="Airflow"),

Review comment:
       Hi @ashb just wanted to double check: I've removed `app_name` in Line:47 
and have replaced `app_name` in the *.html files with `{{ appbuilder.app_name 
}}`. Just wanted to make sure I understood correctly.

##########
File path: airflow/www/extensions/init_jinja_globals.py
##########
@@ -44,6 +44,7 @@ def init_jinja_globals(app):
 
     def prepare_jinja_globals():
         extra_globals = {
+            'app_name': conf.get(section="webserver", key="site_title", 
fallback="Airflow"),

Review comment:
       Hi @ashb just wanted to double check: I've removed `app_name` in Line:47 
and have replaced `app_name` in the relevant *.html files with `{{ 
appbuilder.app_name }}`. Just wanted to make sure I understood correctly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to