dimberman commented on a change in pull request #10315:
URL: https://github.com/apache/airflow/pull/10315#discussion_r490458722
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -138,6 +138,9 @@ class KubernetesPodOperator(BaseOperator): # pylint:
disable=too-many-instance-
:type init_containers: list[kubernetes.client.models.V1Container]
:param log_events_on_failure: Log the pod's events if a failure occurs
:type log_events_on_failure: bool
+ :param retry_only_on_pod_launching_failure: retry logic is only effective
if pod launching fails. This
Review comment:
I'm confused here, how does this know if the image has failed vs. the
other arguments (e.g. a failed volume mount?)
##########
File path: airflow/kubernetes/pod_launcher.py
##########
@@ -187,6 +187,23 @@ def read_pod_logs(self, pod: V1Pod, tail_lines: int = 10):
'There was an error reading the kubernetes API: {}'.format(e)
)
+ @tenacity.retry(
+ stop=tenacity.stop_after_attempt(3),
Review comment:
Is there a reason this is hard-coded? Should # of attempts be
configurable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
