ryanahamilton opened a new pull request #11018:
URL: https://github.com/apache/airflow/pull/11018


   related: apache/airflow#10953
   
   Replaces the PNG + HTML text version of the Airflow logo with an SVG that 
yields both the pinwheel and "Airflow" text. The prior implementation simply 
used the default font-family (Helvetica Neue) for the brand name, where this 
implementation uses the [brand 
font-family](https://cwiki.apache.org/confluence/display/AIRFLOW/Brandbook) 
(Rubik). This ensures that brand font is always locked up with the logo in 
cases where an end-user may apply a custom theme (e.g. different default 
font-family). 
   
   I left the old static asset (`pin_100.png`) in the file system as it appears 
to still be [in use by a Slack 
Operator](https://github.com/apache/airflow/blob/master/airflow/providers/slack/operators/slack.py#L134).
   
   If you stare long enough, you'll see the typography differences 😃
   | Before | After |
   |---|---|
   | 
![image](https://user-images.githubusercontent.com/3267/93630619-4844f980-f9b8-11ea-82fc-6d09072bd54e.png)
  |  
![image](https://user-images.githubusercontent.com/3267/93630461-16339780-f9b8-11ea-889d-402fa170381c.png)|
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to