mik-laj commented on a change in pull request #10987:
URL: https://github.com/apache/airflow/pull/10987#discussion_r491676770
##########
File path: airflow/www/extensions/init_views.py
##########
@@ -73,8 +73,12 @@ def init_plugins(app):
appbuilder = app.appbuilder
for view in plugins_manager.flask_appbuilder_views:
- log.debug("Adding view %s", view["name"])
- appbuilder.add_view(view["view"], view["name"],
category=view["category"])
+ try:
+ log.debug("Adding view %s with menu", view["name"])
+ appbuilder.add_view(view["view"], view["name"],
category=view["category"])
+ except KeyError:
Review comment:
Multiple keys can cause this error. This does not necessarily mean that
the `name` key is missing. What do you think to explicitly check the presence
of the `name` key?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
