potiuk commented on a change in pull request #11033: URL: https://github.com/apache/airflow/pull/11033#discussion_r491693880
########## File path: tests/cluster_policies/task_mutation_connection.py ########## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from airflow.models.pool import Pool + + +# [START task_mutation_connection] +def policy(task): + if task.pool == Pool.DEFAULT_POOL_NAME: + conn_id = getattr(task, 'conn_id') or getattr(task, 'gcp_conn_id') Review comment: Do we have other cases where connection id is specified differently than that in task? Can there be for example tasks that use hooks with default connection ids and connection ids are not specified in the task_id. How are we going to handle those cases? Or maybe we should explicitly state here what are the border conditions for this rule to work? How about transfer operators when we have several different connection ids per task? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
