ashb commented on a change in pull request #10996:
URL: https://github.com/apache/airflow/pull/10996#discussion_r492167746
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -318,7 +320,8 @@ def __init__(self,
self.kube_watcher = self._make_kube_watcher()
def _make_kube_watcher(self) -> KubernetesJobWatcher:
- resource_version = KubeResourceVersion.get_current_resource_version()
+ global global_resource_version # pylint: disable = global-statement
Review comment:
Does this actually need to be global? Even a class-level variable would
be better than an actual global, but an instance property would be best still
if that's possible -- like couldn't this be stored as a property of the
KubernetesExecutor, say?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
