ffinfo commented on a change in pull request #4880: [AIRFLOW-3735] Separate dag
parsing from checking
URL: https://github.com/apache/airflow/pull/4880#discussion_r263994530
##########
File path: tests/core.py
##########
@@ -2193,13 +2193,6 @@ def test_get_connections_env_var(self):
assert conns[0].password == 'password'
assert conns[0].port == 5432
- def test_get_connections_db(self):
- conns = BaseHook.get_connections(conn_id='airflow_db')
- assert len(conns) == 1
- assert conns[0].host == 'localhost'
- assert conns[0].schema == 'airflow'
- assert conns[0].login == 'root'
Review comment:
I did remove this test because it depends on the ENV of the testing. For
example, on travis with postgres this will be host `postgres` instead of
localhost. This specific connection will tested on a lot of places anyway so a
explicit test here it not needed anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
