potiuk commented on pull request #11020: URL: https://github.com/apache/airflow/pull/11020#issuecomment-696319376
This is precisely why It happened @baolsen @kaxil . This is all expected. This is the raw log of the "Build Image" workflow corresponding to your build: https://pipelines.actions.githubusercontent.com/dG18C1r9Veh0Ng8eypyIHvAXk1Mz6Bvz6mj1myj6BZplhvMhGo/_apis/pipelines/1/runs/17875/signedlogcontent/19?urlExpires=2020-09-21T19%3A09%3A38.6094424Z&urlSigningMethod=HMACV1&urlSignature=MVvgOsdVUakamt%2BsTq0HxIU7BQJyTNPzmUsz2u3aySE%3D The line from log: ``` 2020-09-21T13:32:24.8603720Z Requirement already satisfied: moto==1.3.14 in /usr/local/lib/python3.6/site-packages (from -c https://raw.githubusercontent.com/apache/airflow/constraints-master/constraints-3.6.txt (line 236)) (1.3.14) ``` This is perfectly fine. If your change opens up for a newer version, it might not succeed. The constraints will only be updated after merge, when all tests succeed for the upgraded version. this is to protect the PR authors from accidentally failing on seemingly unrelated upgrades in requirements. Imagine you add a new dependency (say presto) and you want to make PR with it - but in the meantime 'moto' latest version starts breaking the build. If we do not use constraint files then those things could happen easily and you would have to fix unrelated problems in your change. The workflow works like that that only AFTER your change is merged, the master build will attempt to upgrade all deps eagerly and it will run all the tests and it will only modify the constraints if all the tests succeed. Than all builds after that constraint push will start using upgraded moto. So in your case, if you locally tested that your change works with latest moto, all is fine. after merge and successful tests in master everyone will be greeted with the updated moto :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
