jhtimmins commented on a change in pull request #10594:
URL: https://github.com/apache/airflow/pull/10594#discussion_r492439382
##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -122,6 +122,7 @@ def _fetch_dag_runs(
limit,
offset,
):
+ total_entries = query.count()
Review comment:
Actually, I think we should maintain the existing behavior here and do
the count prior to the date filtering. Just to keep scope limited. If we decide
that the count should take place after the date filtering, let's make that
behavioral change in a separate PR, just to reduce scope for this one somewhat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
