mik-laj commented on a change in pull request #11034:
URL: https://github.com/apache/airflow/pull/11034#discussion_r491740994
##########
File path: chart/templates/rbac/pod-launcher-role.yaml
##########
@@ -19,7 +19,11 @@
## Airflow Pod Launcher Role
#################################
{{- if and .Values.rbacEnabled .Values.allowPodLaunching }}
+{{- if .Values.multiNamespaceMode }}
kind: ClusterRole
+{{- else }}
+kind: Role
Review comment:
> when you create a Role, you have to specify the namespace it belongs
in.
> ClusterRole, by contrast, is a non-namespaced resource.
https://kubernetes.io/docs/reference/access-authn-authz/rbac/
Can you add namespace?
##########
File path: chart/values.yaml
##########
@@ -545,8 +545,11 @@ config:
worker_container_repository: '{{ .Values.images.airflow.repository |
default .Values.defaultAirflowRepository }}'
worker_container_tag: '{{ .Values.images.airflow.tag | default
.Values.defaultAirflowTag }}'
delete_worker_pods: 'True'
+ multi_namespace_mode: '{{ .Values.multiNamespaceMode }}'
# yamllint enable rule:line-length
+multiNamespaceMode: 'False'
Review comment:
Should we also update README.md? The minimum is updating the reference
documentation, but I'd be happy if you would describe more about what "Multi
namespace mode" means.
https://github.com/apache/airflow/pull/10664
##########
File path: chart/values.yaml
##########
@@ -545,8 +545,11 @@ config:
worker_container_repository: '{{ .Values.images.airflow.repository |
default .Values.defaultAirflowRepository }}'
worker_container_tag: '{{ .Values.images.airflow.tag | default
.Values.defaultAirflowTag }}'
delete_worker_pods: 'True'
+ multi_namespace_mode: '{{ .Values.multiNamespaceMode }}'
# yamllint enable rule:line-length
+multiNamespaceMode: 'False'
Review comment:
Should we also update README.md? The minimum is updating the reference
documentation, but I'd be happy if you would describe more about what "Multi
namespace mode" means.
Reference documentation will be easier to maintain if validation for
values.yml has been added.
https://github.com/apache/airflow/pull/10664
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
