turbaszek commented on a change in pull request #9246:
URL: https://github.com/apache/airflow/pull/9246#discussion_r491865011
##########
File path: airflow/providers/amazon/aws/transfers/s3_to_redshift.py
##########
@@ -112,6 +119,17 @@ def execute(self, context):
copy_options=copy_options,
)
+ if self.truncate_table:
+ truncate_statement = f'TRUNCATE TABLE {self.schema}.{self.table};'
Review comment:
Looking at 107-111 it seems common practise to do queries like this...
there are 7 parameters used to construct the query 🙄 I think we should not
risk any SQL injection but I'm ok with fixing this in a follow up PR or
creating an issue for that so we do not forget about it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
