XD-DENG commented on a change in pull request #4878: [AIRFLOW-4046] Added
validations for poke_interval & timeout for Airflow Sensor
URL: https://github.com/apache/airflow/pull/4878#discussion_r264002773
##########
File path: tests/sensors/test_base_sensor.py
##########
@@ -464,3 +464,45 @@ def test_reschedule_with_test_mode(self):
self.assertEqual(len(task_reschedules), 0)
if ti.task_id == DUMMY_OP:
self.assertEqual(ti.state, State.NONE)
+
+ def test_sensor_with_invalid_poke_interval(self):
+ negative_poke_interval = -10
+ non_number_poke_interval = "abcd"
+ positive_poke_interval = 10
+ with self.assertRaises(AirflowException):
+ sensor = self._make_sensor(
+ return_value=None,
+ poke_interval=negative_poke_interval,
+ timeout=25)
+
+ sensor = self._make_sensor(
+ return_value=None,
+ poke_interval=non_number_poke_interval,
+ timeout=25)
+
+ sensor = self._make_sensor(
+ return_value=None,
+ poke_interval=positive_poke_interval,
+ timeout=25)
+ del sensor
+
+ def test_sensor_with_invalid_timeout(self):
+ negative_timeout = -25
+ non_number_timeout = "abcd"
+ positive_timeout = 25
+ with self.assertRaises(AirflowException):
+ sensor = self._make_sensor(
+ return_value=None,
+ poke_interval=10,
+ timeout=negative_timeout)
+
+ sensor = self._make_sensor(
+ return_value=None,
+ poke_interval=10,
+ timeout=non_number_timeout)
+
+ sensor = self._make_sensor(
+ return_value=None,
+ poke_interval=10,
+ timeout=positive_timeout)
+ del sensor
Review comment:
The same comment here. You can just remove `sensor = ` at line 504, then you
don't need to have this `del sensor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
