ryanahamilton opened a new pull request #11082:
URL: https://github.com/apache/airflow/pull/11082


   Related to #10953 in ongoing efforts to clean up the UI (and prepare for 
broader design updates). Allows the first column of the very crowded DAGs 
(home) view table to be removed.
   
   | Before | After |
   |---|---|
   | 
![image](https://user-images.githubusercontent.com/3267/93902304-66b33980-fcc5-11ea-813b-eaf52ff7b7ed.png)
  |  
![image](https://user-images.githubusercontent.com/3267/93902195-47b4a780-fcc5-11ea-8a37-deca0db6c506.png)
 |
   
   I gather that the DAG Model View used to be editable, but no longer is. The 
[contents that it yields today](https://r.hmlt.in/YEuo581n) is largely 
redundant with the DAG Details view or is data not particularly relevant to the 
end user. I've added a couple of properties to the DAG Details to reconcile the 
removal.
   
   - Added "Parent DAG" to conditionally display on DAG Details when DAG is a 
Sub-DAG. This DAG ID is a link back to the parent DAG.
   - Added the "Tags" for a given DAG on DAG Details. Each tag is a link to the 
DAGs (home) view with the results filtered by that tag.
   - Removed the `DagModelView` class, but relocated its `autocomplete` method 
being used by the DAGs (home) view. Not sure why it was in this class to begin 
with?
   - Updated the DAGs view screenshot in the docs to reflect this change
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to