turbaszek commented on a change in pull request #11019:
URL: https://github.com/apache/airflow/pull/11019#discussion_r493075189
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -89,15 +89,12 @@ def get_conn(self):
if raw_cursor:
conn_args['cursor_factory'] = self._get_cursor(raw_cursor)
# check for ssl parameters in conn.extra
+
for arg_name, arg_val in conn.extra_dejson.items():
- if arg_name in [
- 'sslmode',
- 'sslcert',
- 'sslkey',
- 'sslrootcert',
- 'sslcrl',
- 'application_name',
- 'keepalives_idle',
+ if arg_name not in [
+ 'iam',
+ 'redshift',
+ 'cursor',
Review comment:
I'm not that familiar with psycopg2 but why we exclude those extras?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
