kaxil opened a new pull request #11102:
URL: https://github.com/apache/airflow/pull/11102
Running flake8 pre-commit check should not require docker container to be
started since we don't pass any arguments to it. Note running flake8 through
breeze still works fine, this PR just decouples the scripts. The arguments will
still be passed via `run_static_checks.sh`
**Before**:
As there is a dependency on the scripts inside container
```
❯ pre-commit run flake8 -a
Run
flake8...............................................................Failed
- hook id: flake8
- exit code: 125
docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock.
Is the docker daemon running?.
See 'docker run --help'.
docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock.
Is the docker daemon running?.
See 'docker run --help'.
docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock.
Is the docker daemon running?.
See 'docker run --help'.
```
**Now**:
```
❯ pre-commit run flake8 -a
flake8...................................................................Passed
```
Same results with:
```
❯ ./breeze static-check flake8 -- -a
Checking if the remote image needs to be pulled
Remote docker registry unreachable
Please confirm pull and rebuild image CI-python3.6. Are you sure? [y/N/q]
The answer is 'no'. Skipping pull and rebuild image CI-python3.6.
CI image.
Branch name: master
Docker image: apache/airflow:master-python3.6-ci
Airflow source version: 2.0.0.dev0
Python version: 3.6
DockerHub user: apache
DockerHub repo: airflow
Backend: mysql 5.7
Making sure pre-commit is installed
Running build pre-commit before running the requested static check
Check if image build is
needed...........................................Passed
Running: pre-commit run flake8 --show-diff-on-failure -a
flake8...................................................................Passed
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
