kaxil commented on a change in pull request #11107:
URL: https://github.com/apache/airflow/pull/11107#discussion_r493806953
##########
File path: airflow/providers/ftp/hooks/ftp.py
##########
@@ -248,7 +248,7 @@ def get_mod_time(self, path: str) -> datetime.datetime:
except ValueError:
return datetime.datetime.strptime(time_val, '%Y%m%d%H%M%S')
- def get_size(self, path):
+ def get_size(self, path: str) -> Union[int, str]:
Review comment:
Mypy is going crazy, I would suggest keeping it as
```
def get_size(self, path: str) -> Optional[int]:
```
and do a cast on `return conn.size(path)` as below on L259:
```
return int(conn.size(path))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
