kaxil commented on a change in pull request #10996: URL: https://github.com/apache/airflow/pull/10996#discussion_r493841289
########## File path: airflow/migrations/versions/bef4f3d11e8b_drop_kuberesourceversion_and_.py ########## @@ -0,0 +1,68 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Drop KubeResourceVersion and KubeWorkerId + +Revision ID: bef4f3d11e8b +Revises: e1a11ece99cc +Create Date: 2020-09-22 18:45:28.011654 + +""" + +from alembic import op + +# revision identifiers, used by Alembic. +revision = 'bef4f3d11e8b' +down_revision = 'e1a11ece99cc' +branch_labels = None +depends_on = None + + +WORKER_UUID_TABLE = "kube_worker_uuid" +WORKER_RESOURCEVERSION_TABLE = "kube_resource_version" + + +def upgrade(): + """Apply Drop KubeResourceVersion and KubeWorkerIdentifier tables""" + op.drop_table(WORKER_UUID_TABLE) + op.drop_table(WORKER_RESOURCEVERSION_TABLE) + + +def downgrade(): + """Unapply Drop KubeResourceVersion and KubeWorkerIdentifier tables""" + conn = op.get_bind() + conn.execute( + """ + CREATE TABLE kube_resource_version ( + one_row_id BOOLEAN DEFAULT (1) NOT NULL, + resource_version VARCHAR(255), + PRIMARY KEY (one_row_id), + CONSTRAINT kube_resource_version_one_row_id CHECK (one_row_id), + CHECK (one_row_id IN (0, 1))); + """ + ) + conn.execute( + """ + CREATE TABLE kube_worker_uuid ( + one_row_id BOOLEAN DEFAULT (1) NOT NULL, + worker_uuid VARCHAR(255), + PRIMARY KEY (one_row_id), + CONSTRAINT kube_worker_one_row_id CHECK (one_row_id), + CHECK (one_row_id IN (0, 1))); + """ + ) Review comment: Any reason for plain SQL compared to using alembic / sqlalchemy same as https://github.com/apache/airflow/blob/7644c3708223afef1d9e80cdd7d991bf9cddfa8e/airflow/migrations/versions/86770d1215c0_add_kubernetes_scheduler_uniqueness.py#L38-L65 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
