houqp commented on issue #11086:
URL: https://github.com/apache/airflow/issues/11086#issuecomment-698114566


   yeah, those are two different issues. @madison-ookla what executor are you 
using?
   
   If you run into OOM, the raw task process will receive a SIGKILL instead of 
SIGTERM, which cannot be captured and handled by the process itself. #7025 
doesn't solve this problem because it only handles cases where raw task process 
did not exit by itself or were killed by SIGKILL.
   
   I think to properly fix this bug, we will need to move the failure callback 
invocation into caller of raw task process, e.g. `local_task_job`. That way, we 
can just check for return code from the raw task and always invoke failure 
callback if it's not 0, which should cover the SIGKILL case.
   
   I will update my #10917 PR to cover this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to