KevinYang21 commented on a change in pull request #4889: [AIRFLOW-4057][WIP] statsd should handle invalid characters URL: https://github.com/apache/airflow/pull/4889#discussion_r264028417
########## File path: airflow/settings.py ########## @@ -71,6 +74,43 @@ def timing(cls, stat, dt): Stats = DummyStatsLogger + +ALLOWED_STAT_CHAR = set(string.ascii_letters + string.digits + '_.') Review comment: Do we want to also include `-` as [we allow it in dag_id](https://github.com/apache/airflow/blob/717ddaf737ec1c57244377f73dd0e80e1628576a/airflow/utils/helpers.py#L48)? Maybe it is out of the scope but would be nice if we can have one source of truth REGEX for allowed char. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
