TobKed commented on a change in pull request #8550:
URL: https://github.com/apache/airflow/pull/8550#discussion_r496710739
##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -583,6 +623,49 @@ def start_template_dataflow(
jobs_controller.wait_for_done()
return response["job"]
+ @GoogleBaseHook.fallback_to_default_project_id
+ def start_flex_template(
+ self,
+ body: Dict,
+ location: str,
+ project_id: str,
+ on_new_job_id_callback: Optional[Callable[[str], None]] = None
+ ):
+ """
+ Starts flex templates with the Dataflow pipeline.
+
+ :param body: The request body
Review comment:
I see documentation of the request body is available now:
https://cloud.google.com/dataflow/docs/reference/rest/v1b3/projects.locations.flexTemplates/launch#request-body
Thanks taking care of it @jaketf
I added links to in hook and operator.
In relation to naming I think snake_case is used as standard for python and
camelCase when it is required by external APIs (usually within dictionaries). I
am not sure I understand correctly your question. Could you elaborate please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
