mik-laj commented on a change in pull request #11223: URL: https://github.com/apache/airflow/pull/11223#discussion_r498363356
########## File path: airflow/upgrade/rules/stat_name_handler_not_supported.py ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from airflow.upgrade.rules.base_rule import BaseRule +from tests.plugins.test_plugin import AirflowTestPlugin + + +class StatNameHandlerNotSupportedRule(BaseRule): + + title = 'stat_name_handler field in AirflowTestPlugin is not supported.' + + description = '''\ + stat_name_handler field is no longer supported in AirflowTestPlugin. + Instead there is stat_name_handler option in [scheduler] section of airflow.cfg. + This change is intended to simplify the statsd configuration. + ''' + + def check(self): + if getattr(AirflowTestPlugin, 'stat_name_handler'): Review comment: It is okay that there is this attribute. This allows us to create plugins that are backwards compatible. We should check if the `stat_name_handler` option has been set. If so, skip role. If not, check to see if there are any plugins that use it. If not, skip any further processing. If so, return a message to the user. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
