[
https://issues.apache.org/jira/browse/AIRFLOW-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789024#comment-16789024
]
ASF GitHub Bot commented on AIRFLOW-3891:
-----------------------------------------
astahlman commented on pull request #4893: [DRAFT] [AIRFLOW-3891] Make the
Graph View time-zone aware
URL: https://github.com/apache/airflow/pull/4893
Note: this PR isn't fit to be merged, as it only addresses the Graph
view page. I'm sharing this for early review to make sure it's on the
right track. If there are no major objections to this approach, then
I'll apply similar changes to the other views.
Make sure you have checked _all_ steps below.
### Jira
- [ X ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3891
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement
Proposal([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
### Description
- [ X ] Here are some details about my PR, including screenshots of any UI
changes:
The clock element in the navbar is now a drop-down that allows time-zone
selection from two options: 'UTC' or 'Local' (the browser default). The
default is UTC, and this selection does not persist across page
refreshes. I'm open to suggestions here on whether the time-zone
selection should be "sticky", and if so, what's the right way to make it
so.
The `Base date:` datetimepicker requires a bit of hackery, since the
datetimepicker element bundled with Flask-AppBuilder doesn't seem to
have time zone support (see [1]). To work around this, we have to add an
offset to the (UTC) value in the picker so that the date string
displayed in the picker appears to be in the selected time zone, then
subtract the offset when we read the actual (UTC) value from the picker.
[1] https://github.com/dpgaspar/Flask-AppBuilder/issues/920
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Front-end changes only
### Commits
- [ X ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ X ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Disable unused flask-sqlalchemy modification tracking form webserver
> --------------------------------------------------------------------
>
> Key: AIRFLOW-3891
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3891
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Josh Carp
> Assignee: Josh Carp
> Priority: Trivial
>
> By default, flask-sqlalchemy tracks model changes for its event system, which
> adds some overhead. Since I don't think we're using the flask-sqlalchemy
> event system, we should be able to turn off modification tracking and improve
> performance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
