mik-laj commented on a change in pull request #11229:
URL: https://github.com/apache/airflow/pull/11229#discussion_r498565398
##########
File path: airflow/providers/dingding/hooks/dingding.py
##########
@@ -49,20 +51,20 @@ class DingdingHook(HttpHook):
def __init__(
self,
dingding_conn_id='dingding_default',
- message_type='text',
- message=None,
- at_mobiles=None,
- at_all=False,
+ message_type: str = 'text',
+ message: Union[str, dict, None] = None,
Review comment:
```suggestion
message: Optional[Union[str, dict]] = None,
```
We mark optional arguments in this way. I think it's worth keeping one style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
