[ 
https://issues.apache.org/jira/browse/AIRFLOW-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789102#comment-16789102
 ] 

ASF GitHub Bot commented on AIRFLOW-1526:
-----------------------------------------

zhongjiajie commented on pull request #4895: [AIRFLOW-1526] Add dingding hook 
and operator
URL: https://github.com/apache/airflow/pull/4895
 
 
   Dingding is popular team collaboration tools talk
   just like Slack. This PR is add it to master, could
   help us easy send message to Dingding.
   
   Change db.py add conn dingding_webhook_default, could
   easy configure dingding message due the host is constant
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-1526\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement 
Proposal([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   Add dingding (popular team collaboration tools in China) hook and operator 
to master,
   
   ### Tests
   
   - [x] My PR adds the following unit tests :
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add dingding opeartor
> ---------------------
>
>                 Key: AIRFLOW-1526
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1526
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: operators
>    Affects Versions: 1.8.0
>            Reporter: cocopc
>            Assignee: zhongjiajie
>            Priority: Major
>              Labels: features
>
> h4. This operator implements send message to 
> dingding(https://www.dingtalk.com/),like slack.
> h5. usage scenario example:
> * on task fail, send message to dingding group,rather than  email.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to