[GitHub] [airflow] mik-laj edited a comment on issue #4895: [AIRFLOW-1526] Add dingding hook and operator

Sun, 10 Mar 2019 19:40:30 -0700 

mik-laj edited a comment on issue #4895: [AIRFLOW-1526] Add dingding hook and 
operator
URL: https://github.com/apache/airflow/pull/4895#issuecomment-471385356
 
 
   Do you think it is a good idea to allow tokens to be passed as an operator 
parameter? For me it is not safe. 
   First, operator parameters are not stored securely. Connection use a fernet 
   Reference: 
https://airflow.readthedocs.io/en/latest/howto/secure-connections.html#rotating-encryption-keys
   Second: operators parameters is available in UI. This extends the group of 
people who have access to the token.
   ![0 0 0 0_8009_task_execution_date=2019-03-09T00%3A00%3A00%2B00%3A00 
dag_id=example_bash_operator 
task_id=runme_0](https://user-images.githubusercontent.com/12058428/54097115-f37df700-43ae-11e9-98f1-2f2cac159fcd.png)
   
   Similar comment from today: 
https://github.com/apache/airflow/pull/4891/files#r264048383
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to