[GitHub] [airflow] potiuk commented on pull request #11268: Improve running and canceliling of the PR-triggered builds.

[GitBox]

potiuk commented on pull request #11268:
URL: https://github.com/apache/airflow/pull/11268#issuecomment-703310069


   On top of fixing the dreadful #10471 problem with merge PRs, this one adds 
useful, informative messages for contriibutors - directly in the PR comments.
   
   You can see several examples of the PRs run on my private fork: 
   
   https://github.com/potiuk/airflow/pulls
   
   Just a few screenshots:
   
   This is a comment that will be automatically posted when PR starts. It 
supplements missing feature of GitHub to provide a link to 'workflow_run' 
triggered event: this way the PR creators will get the link to the "Build 
Image" workflow for their PR - directly as comment in the PR:
   
   <img width="969" alt="Screenshot 2020-10-04 at 22 07 46" 
src="https://user-images.githubusercontent.com/595491/95025968-258c3380-068e-11eb-9b2b-1beecec3a2b7.png";>
   
   
   When they will get the image build failure, they will get this comment in 
their PR (they will be able to click trough to get:
   
   <img width="958" alt="Screenshot 2020-10-04 at 22 11 25" 
src="https://user-images.githubusercontent.com/595491/95026039-ae0ad400-068e-11eb-9fe3-c95cb2a9be46.png";>
   
   
   Also, if there is a reason for cancelling a build (duplicate runs, failing 
jobs) the users will get a message as comment in their PRs, explaining why 
their PR builds got cancelled.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org