ashb commented on a change in pull request #10956:
URL: https://github.com/apache/airflow/pull/10956#discussion_r499574149
##########
File path: tests/www/test_views.py
##########
@@ -639,10 +638,10 @@ def test_view_uses_existing_dagbag(self, endpoint):
self.check_content_in_response('example_bash_operator', resp)
@parameterized.expand([
- ("hello\nworld", r'\"conf\":{\"abc\":\"hello\\nworld\"}}'),
- ("hello'world", r'\"conf\":{\"abc\":\"hello\\u0027world\"}}'),
- ("<script>", r'\"conf\":{\"abc\":\"\\u003cscript\\u003e\"}}'),
- ("\"", r'\"conf\":{\"abc\":\"\\\"\"}}'),
+ ("hello\nworld", r'\"conf\":{\"abc\":\"hello\\nworld\"}'),
Review comment:
Extra params now appear in the output, so the closing `}` is now a `,`.
The extra params that show up are the two new date fields I added to the
model, as we use `sqlalchemy_to_dict` here so we get all the columns showing up
in the JSON.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
