turbaszek commented on a change in pull request #11285: URL: https://github.com/apache/airflow/pull/11285#discussion_r499744010
########## File path: tests/upgrade/rules/test_airflow_macro_plugin_removed.py ########## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from unittest import TestCase + +from tempfile import NamedTemporaryFile +from tests.compat import mock + +from airflow.upgrade.rules.airflow_macro_plugin_removed import AirflowMacroPluginRemovedRule + + [email protected]("airflow.upgrade.rules.airflow_macro_plugin_removed.list_py_file_paths") +class TestAirflowMacroPluginRemovedRule(TestCase): + def setUp(self): + self.temp_file = NamedTemporaryFile("w+") + + def create_temp_file(self, mock_list_files, lines): + mock_list_files.return_value = [self.temp_file.name] + for line in lines: + self.temp_file.write(line) + self.temp_file.write("\n") + self.temp_file.flush() Review comment: Please create here the temporary file and close it. Otherwise, there's is side effect between tests. You may consider creating context manger (using `@contextmanager` decorator) that with handle it and then you can do ```python with create_temp_file(lines): # do something here ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
