ashb opened a new pull request #11306:
URL: https://github.com/apache/airflow/pull/11306
A rare race condition was noticed in the Scheduler HA PR where the
"test_dags_with_system_exit" test would occasionally fail with the
following symptoms:
- The pipe was "readable" as returned by
`multiprocessing.connection.wait`
- On reading it yielded an EOFError, meaning the other side had closed
the connection
- But the process was still alive/running
This previously would result in the Manager process dying with an error.
This PR makes a few changes:
- It ensures that the pipe is simplex, not duplex (we only ever send one
data) as this is simpler
- We ensure that the "other" end of the pipe is correctly closed in both
parent and child processes. Without this the pipe would be kept open
(sometimes) until the child process had closed anyway.
- When we get an EOFError on reading and the process is still alive, we
give it a few seconds to shut down cleanly, and then kill it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
