ivica-k commented on a change in pull request #11227:
URL: https://github.com/apache/airflow/pull/11227#discussion_r500394750



##########
File path: airflow/providers/amazon/aws/transfers/redshift_to_s3.py
##########
@@ -104,28 +107,42 @@ def __init__(  # pylint: disable=too-many-arguments
                 'HEADER',
             ]
 
+    def _build_unload_query(self, credentials, select_query, s3_key, 
unload_options):

Review comment:
       I'm a bit confused about the type for `credentials`. My debugger shows 
it's of type `ReadOnlyCredentials` which in turn is a `NamedTuple`. Which type 
should I put for `credentials`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to