ashb commented on a change in pull request #10956:
URL: https://github.com/apache/airflow/pull/10956#discussion_r500572553
##########
File path: airflow/models/dagbag.py
##########
@@ -510,6 +513,6 @@ def sync_to_db(self):
DAG.bulk_sync_to_db(self.dags.values())
# Write Serialized DAGs to DB if DAG Serialization is turned on
# Even though self.read_dags_from_db is False
- if settings.STORE_SERIALIZED_DAGS:
+ if settings.STORE_SERIALIZED_DAGS or self.read_dags_from_db:
Review comment:
This change was a bit of a hack here, and we'll tidy it up.
Since the scheduler now requires DAG serialization to operate, we need a way
for dag bags to Load dags from given files only, and not from the DB, but then
also a way to make them _write_ things back to the DB.
We'll pull this out in to a separate PR, essentially removing the
`STORE_SERIALIZED_DAGS` option entirely, and then this bulk_sync_to_db can then
just always write to the DB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
