kaxil commented on a change in pull request #10956:
URL: https://github.com/apache/airflow/pull/10956#discussion_r500609846
##########
File path: airflow/models/dag.py
##########
@@ -1573,34 +1680,28 @@ def create_dagrun(self,
@classmethod
@provide_session
- def bulk_sync_to_db(cls, dags: Collection["DAG"], sync_time=None,
session=None):
+ def bulk_sync_to_db(cls, dags: Collection["DAG"], session=None):
Review comment:
I think we should change the name, I agree with Kamil and Jarek that it
now does a bit more than just "sync_to_db" which for me is like flushing
current state to DB.
Maybe `bulk_sync_to_db_and_set_next_dagrun` ? and we could extract the
statements that set next dag run to a separate method (`_set_next_dag_run`)
that is called from this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
