ashb commented on a change in pull request #11327:
URL: https://github.com/apache/airflow/pull/11327#discussion_r500895612
##########
File path: airflow/executors/local_executor.py
##########
@@ -65,14 +74,31 @@ def execute_work(self, key: TaskInstanceKey, command:
CommandType) -> None:
if key is None:
return
self.log.info("%s running %s", self.__class__.__name__, command)
+ old_title = getproctitle()
try:
- subprocess.check_call(command, close_fds=True)
+ from airflow.cli.cli_parser import get_parser
+ parser = get_parser()
+ # [1:] - remove "airflow" from the start of the command
+ args = parser.parse_args(command[1:])
Review comment:
Oh I hadn't seen that PR (or forgotten about it).
Hmm, not sure - yes plugins would be pre-loaded. I guess this Congress down
to not recommending putting operators in plugins too.
I'll add a config flag (on by default?) to go back to the old way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
