[
https://issues.apache.org/jira/browse/AIRFLOW-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789327#comment-16789327
]
ASF GitHub Bot commented on AIRFLOW-4063:
-----------------------------------------
RosterIn commented on pull request #4899: [AIRFLOW-4063] - fix exception string
in BigQueryHook
URL: https://github.com/apache/airflow/pull/4899
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4063
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement
Proposal([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
### Description
The `%s` in the current string isn't replaced with the error code:
Before:
```
Python 3.6.7 (default, Oct 21 2018, 04:56:05)
Type "help", "copyright", "credits" or "license" for more information.
>>> raise Exception( 'BigQuery job status check failed. Final error was:
%s', 404)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
Exception: ('BigQuery job status check failed. Final error was: %s', 404)
```
After:
```
>>> raise Exception( 'BigQuery job status check failed. Final error was:
{}'.format( 404))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
Exception: BigQuery job status check failed. Final error was: 404
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> fix string in Exception of BigQueryHook
> ---------------------------------------
>
> Key: AIRFLOW-4063
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4063
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: RosterIn
> Priority: Minor
>
> The exception handling in run_with_configuration isn't formating the string
> properly.
> PR will follow shortly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
