ramandumcs commented on a change in pull request #4859: [AIRFLOW-3917] Added
config to support running scheduler(with kuberne…
URL: https://github.com/apache/airflow/pull/4859#discussion_r264180715
##########
File path: airflow/contrib/kubernetes/kube_client.py
##########
@@ -46,6 +46,8 @@ def _load_kube_config(in_cluster, cluster_context,
config_file):
def get_kube_client(in_cluster=conf.getboolean('kubernetes', 'in_cluster'),
- cluster_context=None,
- config_file=None):
+ cluster_context=None if not conf.get('kubernetes',
'cluster_context') else
+ conf.get('kubernetes', 'cluster_context'),
+ config_file=None if not conf.get('kubernetes',
'config_file') else
+ conf.get('kubernetes', 'config_file')):
Review comment:
Thanks @ashb I have incorporated comments. I have observed that
conf.get('kubernetes', 'cluster_context', fallback=None) fallbacks to None if
key i.e cluster_context is not defined in airflow.cfg file. In our case it
returns a empty string which breaks the kube_client initialisation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
