mlgruby commented on a change in pull request #11359:
URL: https://github.com/apache/airflow/pull/11359#discussion_r502021889
##########
File path:
airflow/providers/microsoft/azure/operators/azure_container_instances.py
##########
@@ -136,16 +136,16 @@ def __init__(
name: str,
image: str,
region: str,
- environment_variables: Optional[Dict[Any, Any]] = None,
+ environment_variables: Optional[dict] = None,
secured_variables: Optional[str] = None,
- volumes: Optional[List[Any]] = None,
+ volumes: Optional[list] = None,
memory_in_gb: Optional[Any] = None,
cpu: Optional[Any] = None,
gpu: Optional[Any] = None,
command: Optional[str] = None,
remove_on_error: bool = True,
fail_if_exists: bool = True,
- tags: Optional[Dict[str, str]] = None,
+ tags: Optional[dict] = None,
Review comment:
it is, but I thought with python 3.9 we can have dict[str, str], hence
kept it as dict only. Maybe I am thinking in future! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
