ashb commented on a change in pull request #11330:
URL: https://github.com/apache/airflow/pull/11330#discussion_r501807593
##########
File path: chart/values.yaml
##########
@@ -288,6 +288,7 @@ workers:
# Airflow scheduler settings
scheduler:
+ replicas: 2
Review comment:
```suggestion
replicas: 1
```
Default needs to stay at 1 I think
##########
File path: chart/values.yaml
##########
@@ -28,10 +28,10 @@ gid: 50000
airflowHome: "/opt/airflow"
# Default airflow repository -- overrides all the specific images below
-defaultAirflowRepository: apache/airflow
+defaultAirflowRepository: dimberman/airflow
# Default airflow tag to deploy
-defaultAirflowTag: 1.10.12
+defaultAirflowTag: scheduler-ha-with-dags-0.1
Review comment:
Need to revert these :)
##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -46,7 +46,7 @@ spec:
{{- if $stateful }}
serviceName: {{ .Release.Name }}-scheduler
{{- end }}
- replicas: 1
+ replicas: {{ .Values.scheduler.replicas }}
Review comment:
I wonder if there's any way we can guard this to only work for 2.0.0 --
but given users might use their own Docker image I don't think there's much we
can really do.
I guess just make it clear in the values.yaml file do not set this >1 unless
you are on 2.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
