ephraimbuddy opened a new pull request #11408: URL: https://github.com/apache/airflow/pull/11408
This PR addresses a few things. 1) Incorrect type for command argument: The correct type is List[str] and is now updated 2) I added os_type and restart_policy arguments so that it's not hardcoded. 3) I also added ip_address and ports argument so that these values can be configured on the container at the start. Without these, there's no way of getting a generated IP and FQDN from azure when you run containers such as the [microsoft/aci-helloworld](https://hub.docker.com/_/microsoft-azuredocs-aci-helloworld) --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
