dchaplinsky commented on issue #4891: [AIRFLOW-4067] Telegram hook/operator to 
post messages to telegram channels
URL: https://github.com/apache/airflow/pull/4891#issuecomment-471750976
 
 
   @mik-laj let's discuss the thing about retry decorator here if you don't 
mind.
   
   # I'm not exposing it outside, it's not intended for reuse (I checked 
airflow code and found no native decorators/tools for that task).
   # That's a third-party code released under the public domain. I don't feel 
good about rewriting it because of a style, since it's not mine and it's not 
exposed outside of the module.
   
   So we have three ways to solve it:
   # Drop it completely. That might have unpleasant consequences because from 
my experience sometime telegram api client dies because of timeout. Especially 
if you are sending a lot.
   # Leave it as is
   # Rewrite it partially or completely
   
   Please advice, taking into account my points above about visibility and 
authorship.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to