turbaszek commented on a change in pull request #11434:
URL: https://github.com/apache/airflow/pull/11434#discussion_r502968374
##########
File path: airflow/providers/amazon/aws/transfers/hive_to_dynamodb.py
##########
@@ -64,18 +65,18 @@ class HiveToDynamoDBOperator(BaseOperator):
def __init__( # pylint: disable=too-many-arguments
self,
*,
- sql,
- table_name,
- table_keys,
- pre_process=None,
- pre_process_args=None,
- pre_process_kwargs=None,
- region_name=None,
- schema='default',
- hiveserver2_conn_id='hiveserver2_default',
- aws_conn_id='aws_default',
+ sql: str,
+ table_name: str,
+ table_keys: list,
+ pre_process: Optional[Callable[[Any, Optional[list], Optional[list]],
Iterable]] = None,
Review comment:
```suggestion
pre_process: Optional[Callable] = None,
```
No strong opinion but this long type is too much complicated for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
